Skip to content

chore: cleanup codegen#965

Merged
steveiliop56 merged 1 commit into
mainfrom
chore/cleanup-gen
Jul 2, 2026
Merged

chore: cleanup codegen#965
steveiliop56 merged 1 commit into
mainfrom
chore/cleanup-gen

Conversation

@steveiliop56

@steveiliop56 steveiliop56 commented Jul 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation
    • Added automated documentation generation during the project’s generation workflow.
  • Chores
    • Updated the generation process to run across the full codebase in one step.
    • Improved CI checks to better detect outdated generated files and unexpected untracked files.
    • Standardized generator command references for database-related code generation.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d4d14af3-daa6-47b9-b02b-9f1a382c3f78

📥 Commits

Reviewing files that changed from the base of the PR and between a3c4d6a and 7eac935.

⛔ Files ignored due to path filters (5)
  • gen/docs/gen.go is excluded by !**/gen/**
  • gen/docs/gen_env.go is excluded by !**/gen/**
  • gen/docs/gen_md.go is excluded by !**/gen/**
  • gen/sqlc_wrapper/sqlc_wrapper.go is excluded by !**/gen/**
  • gen/sqlc_wrapper/store.tmpl is excluded by !**/gen/**
📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • Makefile
  • generate.go
  • internal/repository/postgres/generate.go
  • internal/repository/sqlite/generate.go
📝 Walkthrough

Walkthrough

Consolidates Go code generation to run repo-wide via go generate ./..., adds a new top-level generate.go for docs generation, renames the sqlc-wrapper generator package to sqlc_wrapper in postgres and sqlite repository generate.go files, and updates the Makefile and CI workflow accordingly.

Changes

Code Generation Consolidation

Layer / File(s) Summary
Top-level docs generator and sqlc wrapper rename
generate.go, internal/repository/postgres/generate.go, internal/repository/sqlite/generate.go		 New generate.go adds a //go:generate directive for docs generation; postgres and sqlite generate.go files switch generator path from gen/sqlc-wrapper to gen/sqlc_wrapper.
Makefile and CI generation scope update
Makefile, .github/workflows/ci.yml		 Makefile generate target now runs a single go generate ./... instead of go run ./gen plus scoped generation; CI check broadens generation and diff-cleanliness validation to the whole repository.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • tinyauthapp/tinyauth#831: Introduced/updated the SQLC code generation plumbing that this PR further modifies by renaming sqlc-wrapper to sqlc_wrapper.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR’s main theme of cleaning up code generation and is concise and relevant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cleanup-gen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gen/sqlc_wrapper/sqlc_wrapper.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 2, 2026
@steveiliop56 steveiliop56 merged commit 440a3a3 into main Jul 2, 2026
5 checks passed
@steveiliop56 steveiliop56 deleted the chore/cleanup-gen branch July 2, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rycochet Rycochet Rycochet approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steveiliop56 @Rycochet